Add line-height property - #12649
Open
tilladam wants to merge 1 commit into
Open
Conversation
tilladam
force-pushed
the
line-height-property
branch
from
July 26, 2026 20:22
1546af4 to
0c964fb
Compare
Expose a font-size-relative line height on Text, TextInput, and StyledText. Apply it consistently in Parley, testing, and software-renderer layout, including measurement, elision, and cursor positioning. Document the property and cover the layout and hit-testing behavior. ChangeLog: Add line-height to Text, TextInput, and StyledText.
tilladam
force-pushed
the
line-height-property
branch
from
July 27, 2026 14:15
0c964fb to
80ac6c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
line-heightproperty toText,TextInput, andStyledText.Rationale
Line height is a paragraph layout primitive shared by plain, editable, and styled text.
Slint already represents it internally with Parley's
FontSizeRelativeline height, so this exposes the existing capability without adding span-specific styling rules.Testing
cargo test -p i-slint-core textlayoutSLINT_TEST_FILTER=line_height cargo test --manifest-path tests/Cargo.toml -p test-driver-rustSLINT_TEST_FILTER=line_height cargo test --manifest-path tests/Cargo.toml -p test-driver-interpretercargo test -p i-slint-renderer-software custom_line_height_uses_requested_font_sizecargo test -p i-slint-compiler --features display-diagnostics --test syntax_testscargo check -p i-slint-renderer-software --no-default-features --features libm,i-slint-core/unsafe-single-threadedcargo clippy --all --workspacecargo doc -p i-slint-core --no-deps